[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb71f83d4897ce818348522d9594b091478073ff.camel@pengutronix.de>
Date: Wed, 19 Jan 2022 11:51:20 +0100
From: Lucas Stach <l.stach@...gutronix.de>
To: Yongzhi Liu <lyz_cs@....edu.cn>, linux+etnaviv@...linux.org.uk,
christian.gmeiner@...il.com, airlied@...ux.ie, daniel@...ll.ch,
etnaviv@...ts.freedesktop.org
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/etnaviv: Add missing pm_runtime_put
Am Dienstag, dem 18.01.2022 um 06:16 -0800 schrieb Yongzhi Liu:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code, thus a matching decrement is needed
> on the error handling path to keep the counter balanced.
>
Instead of adding more error handling code here, I would prefer to
convert this to pm_runtime_resume_and_get to avoid this issue.
Regards,
Lucas
> Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 242a5fd..5e81a98 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1714,6 +1714,9 @@ static int etnaviv_gpu_bind(struct device *dev, struct device *master,
> return 0;
>
> out_sched:
> +#ifdef CONFIG_PM
> + pm_runtime_put_autosuspend(gpu->dev);
> +#endif
> etnaviv_sched_fini(gpu);
>
> out_workqueue:
Powered by blists - more mailing lists