linux-kernel - Re: Re: [PATCH] drm/etnaviv: Add missing pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <480fc77e.24a14.17e721fffbe.Coremail.lyz_cs@pku.edu.cn>
Date:   Wed, 19 Jan 2022 19:36:46 +0800 (GMT+08:00)
From:   刘永志 <lyz_cs@....edu.cn>
To:     "lucas stach" <l.stach@...gutronix.de>
Cc:     linux+etnaviv@...linux.org.uk, christian.gmeiner@...il.com,
        airlied@...ux.ie, daniel@...ll.ch, etnaviv@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] drm/etnaviv: Add missing pm_runtime_put

> -----原始邮件-----
> 发件人: "Lucas Stach" <l.stach@...gutronix.de>
> 发送时间: 2022-01-19 18:51:20 (星期三)
> 收件人: "Yongzhi Liu" <lyz_cs@....edu.cn>, linux+etnaviv@...linux.org.uk, christian.gmeiner@...il.com, airlied@...ux.ie, daniel@...ll.ch, etnaviv@...ts.freedesktop.org
> 抄送: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
> 主题: Re: [PATCH] drm/etnaviv: Add missing pm_runtime_put
> 
> Am Dienstag, dem 18.01.2022 um 06:16 -0800 schrieb Yongzhi Liu:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > when it returns an error code, thus a matching decrement is needed
> > on the error handling path to keep the counter balanced.
> > 
> Instead of adding more error handling code here, I would prefer to
> convert this to pm_runtime_resume_and_get to avoid this issue.
> 
> Regards,
> Lucas
> 

I will resend my modified patch. Thanks for your reply.

> > Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
> > ---
> >  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > index 242a5fd..5e81a98 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > @@ -1714,6 +1714,9 @@ static int etnaviv_gpu_bind(struct device *dev, struct device *master,
> >  	return 0;
> >  
> >  out_sched:
> > +#ifdef CONFIG_PM
> > +	pm_runtime_put_autosuspend(gpu->dev);
> > +#endif
> >  	etnaviv_sched_fini(gpu);
> >  
> >  out_workqueue:
>