linux-kernel - Re: [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization into function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfD2iOF+nkCtOGyAd7sadxJWL2yFKo+zXcrv6E-ADU98g@mail.gmail.com>
Date:   Wed, 19 Jan 2022 13:40:20 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Terry Bowman <terry.bowman@....com>
Cc:     Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Robert Richter <rrichter@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Mario Limonciello <Mario.Limonciello@....com>
Subject: Re: [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization
 into function

On Tue, Jan 18, 2022 at 10:22 PM Terry Bowman <terry.bowman@....com> wrote:
>
> Refactor driver's timer initialization into new function. This is needed
> inorder to support adding new device layouts while using common timer
> initialization.

> Co-developed-by: Robert Richter <rrichter@....com>
> Signed-off-by: Robert Richter <rrichter@....com>
> Signed-off-by: Terry Bowman <terry.bowman@....com>

> To: Guenter Roeck <linux@...ck-us.net>
> To: linux-watchdog@...r.kernel.org
> To: Jean Delvare <jdelvare@...e.com>
> To: linux-i2c@...r.kernel.org
> To: Wolfram Sang <wsa@...nel.org>
> To: Andy Shevchenko <andy.shevchenko@...il.com>
> To: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Robert Richter <rrichter@....com>
> Cc: Thomas Lendacky <thomas.lendacky@....com>

Please, do not pollute commit messages with this rather unnecessary
list of recipients. There are (at least?) two possibilities:
- use --cc and --to whe run `git send-email`
- move them under the cutter '--- ' line below

> ---

> +       val = readl(SP5100_WDT_CONTROL(tco->tcobase));
> +       if (val & SP5100_WDT_DISABLED) {
> +               dev_err(dev, "Watchdog hardware is disabled\n");
> +               return(-ENODEV);

Missed space, too many parentheses.

> +       }

-- 
With Best Regards,
Andy Shevchenko