linux-kernel - Re: [PATCH 10/26] x86/tdx: Support TDX guest port I/O at decompression time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jan 2022 20:46:24 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        mingo@...hat.com, dave.hansen@...el.com, luto@...nel.org,
        peterz@...radead.org, sathyanarayanan.kuppuswamy@...ux.intel.com,
        aarcange@...hat.com, ak@...ux.intel.com, dan.j.williams@...el.com,
        david@...hat.com, jgross@...e.com, jmattson@...gle.com,
        joro@...tes.org, jpoimboe@...hat.com, knsathya@...nel.org,
        pbonzini@...hat.com, sdeep@...are.com, seanjc@...gle.com,
        tony.luck@...el.com, vkuznets@...hat.com, wanpengli@...cent.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/26] x86/tdx: Support TDX guest port I/O at
 decompression time

On Wed, Jan 19, 2022 at 06:49:25PM +0300, Kirill A. Shutemov wrote:
> const struct port_io_ops default_pio_ops = {
> 	.inb = inb,
> 	.inw = inw,
> 	.inl = inl,
> 	.outb = outb,
> 	.outw = outw,
> 	.outl = outl,
> };
> 
> make pio_ops a pointer and assign it here:
> 
> 	pio_ops = &default_pio_ops;
> 
> But it leads to an issue on linking:
> 
> ld.lld: error: Unexpected run-time relocations (.rela) detected!

So the above generates absolute relocations of type R_X86_64_64

Relocation section '.rela.data.rel.local' at offset 0x5c18 contains 6 entries:
  Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000000  000200000001 R_X86_64_64       0000000000000000 .text + 10
000000000008  000200000001 R_X86_64_64       0000000000000000 .text + 30
000000000010  000200000001 R_X86_64_64       0000000000000000 .text + 50
000000000018  000200000001 R_X86_64_64       0000000000000000 .text + 0
000000000020  000200000001 R_X86_64_64       0000000000000000 .text + 20
000000000028  000200000001 R_X86_64_64       0000000000000000 .text + 40

and the linker doesn't like them probably because of the mcmodel we use
but I need to talk to toolchain folks first to make sense of what's
going on...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette