linux-kernel - Re: [PATCH 10/26] x86/tdx: Support TDX guest port I/O at decompression time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220119200841.fupa3hemmswllmxc@box.shutemov.name>
Date:   Wed, 19 Jan 2022 23:08:41 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Borislav Petkov <bp@...en8.de>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        mingo@...hat.com, dave.hansen@...el.com, luto@...nel.org,
        peterz@...radead.org, sathyanarayanan.kuppuswamy@...ux.intel.com,
        aarcange@...hat.com, ak@...ux.intel.com, dan.j.williams@...el.com,
        david@...hat.com, jgross@...e.com, jmattson@...gle.com,
        joro@...tes.org, jpoimboe@...hat.com, knsathya@...nel.org,
        pbonzini@...hat.com, sdeep@...are.com, seanjc@...gle.com,
        tony.luck@...el.com, vkuznets@...hat.com, wanpengli@...cent.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/26] x86/tdx: Support TDX guest port I/O at
 decompression time

On Wed, Jan 19, 2022 at 08:46:24PM +0100, Borislav Petkov wrote:
> On Wed, Jan 19, 2022 at 06:49:25PM +0300, Kirill A. Shutemov wrote:
> > const struct port_io_ops default_pio_ops = {
> > 	.inb = inb,
> > 	.inw = inw,
> > 	.inl = inl,
> > 	.outb = outb,
> > 	.outw = outw,
> > 	.outl = outl,
> > };
> > 
> > make pio_ops a pointer and assign it here:
> > 
> > 	pio_ops = &default_pio_ops;
> > 
> > But it leads to an issue on linking:
> > 
> > ld.lld: error: Unexpected run-time relocations (.rela) detected!
> 
> So the above generates absolute relocations of type R_X86_64_64
> 
> Relocation section '.rela.data.rel.local' at offset 0x5c18 contains 6 entries:
>   Offset          Info           Type           Sym. Value    Sym. Name + Addend
> 000000000000  000200000001 R_X86_64_64       0000000000000000 .text + 10
> 000000000008  000200000001 R_X86_64_64       0000000000000000 .text + 30
> 000000000010  000200000001 R_X86_64_64       0000000000000000 .text + 50
> 000000000018  000200000001 R_X86_64_64       0000000000000000 .text + 0
> 000000000020  000200000001 R_X86_64_64       0000000000000000 .text + 20
> 000000000028  000200000001 R_X86_64_64       0000000000000000 .text + 40
> 
> and the linker doesn't like them probably because of the mcmodel we use
> but I need to talk to toolchain folks first to make sense of what's
> going on...

JFYI, the message comes from ASSERT in vmlinux.lds.S.

I assume for now I can proceed with the assignment that works, right?
It can be changed later once we figure out what is going on.

-- 
 Kirill A. Shutemov