linux-kernel - Re: [PATCH -next] fanotify: remove variable set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220120125745.axdqtnasbivkulsm@quack3.lan>
Date:   Thu, 20 Jan 2022 13:57:45 +0100
From:   Jan Kara <jack@...e.cz>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     jack@...e.cz, amir73il@...il.com, repnop@...gle.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] fanotify: remove variable set but not used

On Wed 12-01-22 16:54:03, Yang Li wrote:
> The code that uses the pointer info has been removed in
> 'https://lore.kernel.org/all/20211129201537.1932819-11-amir73il@gmail.com/'
> and fanotify_event_info() doesn't change 'event', so the declaration and 
> assignment of info can be removed.
> 
> Eliminate the following clang warning:
> fs/notify/fanotify/fanotify_user.c:161:24: warning: variable ‘info’ set
> but not used
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Thanks! I've added the patch to my tree.

								Honza

> ---
>  fs/notify/fanotify/fanotify_user.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
> index 73b1615f9d96..1026f67b1d1e 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -158,7 +158,6 @@ static size_t fanotify_event_len(unsigned int info_mode,
>  				 struct fanotify_event *event)
>  {
>  	size_t event_len = FAN_EVENT_METADATA_LEN;
> -	struct fanotify_info *info;
>  	int fh_len;
>  	int dot_len = 0;
>  
> @@ -168,8 +167,6 @@ static size_t fanotify_event_len(unsigned int info_mode,
>  	if (fanotify_is_error_event(event->mask))
>  		event_len += FANOTIFY_ERROR_INFO_LEN;
>  
> -	info = fanotify_event_info(event);
> -
>  	if (fanotify_event_has_any_dir_fh(event)) {
>  		event_len += fanotify_dir_name_info_len(event);
>  	} else if ((info_mode & FAN_REPORT_NAME) &&
> -- 
> 2.20.1.7.g153144c
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR