linux-kernel - Re: [PATCH] x86/sgx: Add poison handling to reclaimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80083e5ca3fd0a5bd2de43ebc803fc914d09ac3c.camel@kernel.org>
Date:   Thu, 20 Jan 2022 14:57:56 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Reinette Chatre <reinette.chatre@...el.com>, tony.luck@...el.com,
        dave.hansen@...ux.intel.com, tglx@...utronix.de, bp@...en8.de,
        luto@...nel.org, mingo@...hat.com, linux-sgx@...r.kernel.org,
        x86@...nel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/sgx: Add poison handling to reclaimer

On Tue, 2022-01-18 at 15:05 -0800, Reinette Chatre wrote:
> The machine check recovery handling in SGX added the changes
> listed below to the freeing of pages in sgx_free_epc_page().
> The SGX reclaimer contains an open coded version of
> sgx_free_epc_page() and thus did not obtain the changes in
> support of poison handling.
> 
> The changes made to EPC page freeing in support of poison handling
> are:
> 1) A new SGX_EPC_PAGE_IS_FREE flag is set when the EPC page is
>    freed. Introduced in commit d6d261bded8a ("x86/sgx: Add new
>    sgx_epc_page flag bit to mark free pages").
> 2) A new "poison" field in struct sgx_epc_page is used to
>    determine whether a newly freed EPC page should be placed
>    on the list of poisoned or list of free pages. Introduced
>    in commit 992801ae9243 ("x86/sgx: Initial poison handling
>    for dirty and free pages").
> 3) The owner field in struct sgx_epc_page is cleared when the EPC
>    page is freed.  Introduced in commit 992801ae9243 ("x86/sgx:
>    Initial poison handling for dirty and free pages").
> 
> Replace the open coded enclave page freeing code in the reclaimer
> with sgx_free_epc_page() to obtain support for poison page handling.
> 
> Fixes: d6d261bded8a ("x86/sgx: Add new sgx_epc_page flag bit to mark
> free pages")

AFAIK, this patch does not semantically break anything so it is not
a legit fixes tag.

BR, Jarkko