linux-kernel - Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd7a212e-71ff-90a6-d3dc-1391567fc113@gmail.com>
Date:   Thu, 20 Jan 2022 15:59:51 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Ashish Mhetre <amhetre@...dia.com>, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-tegra@...r.kernel.org,
        krzysztof.kozlowski@...onical.com, linux-kernel@...r.kernel.org
Cc:     Snikam@...dia.com, vdumpa@...dia.com
Subject: Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

20.01.2022 12:02, Ashish Mhetre пишет:
> @@ -521,23 +535,64 @@ static irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
>  
>  	for_each_set_bit(bit, &status, 32) {
>  		const char *error = tegra_mc_status_names[bit] ?: "unknown";
> +		u32 status_reg = MC_ERR_STATUS, addr_reg = MC_ERR_ADR;

No need to initialize these variables, since they are always initialized
by the further code.

Please write it like this:

u32 addr_hi_reg = 0, status_reg, addr_reg;