linux-kernel - Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ef23e26-fcde-e2b7-d4d7-c4fc68c1ca90@gmail.com>
Date:   Thu, 20 Jan 2022 16:06:58 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Ashish Mhetre <amhetre@...dia.com>, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-tegra@...r.kernel.org,
        krzysztof.kozlowski@...onical.com, linux-kernel@...r.kernel.org
Cc:     Snikam@...dia.com, vdumpa@...dia.com
Subject: Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

20.01.2022 12:02, Ashish Mhetre пишет:
> +		default:
> +			status_reg = MC_ERR_STATUS;
> +			addr_reg = MC_ERR_ADR;
> +#if defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> +    defined(CONFIG_ARCH_TEGRA_234_SOC)
> +			addr_hi_reg = MC_ERR_ADR_HI;
> +#endif

I'd add new "has_addr_hi_reg" field to struct tegra_mc_soc and use it
instead of the ifdefs.

if (mc->soc->has_addr_hi_reg)
	addr_hi_reg = MC_ERR_ADR_HI;