linux-kernel - Re: [PATCH v3 1/9] kernel/resource: Introduce request_muxed_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00ef380e-cf39-6fb8-bb64-795d3dc5d14f@amd.com>
Date:   Thu, 20 Jan 2022 07:53:33 -0600
From:   Terry Bowman <Terry.Bowman@....com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Robert Richter <rrichter@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        sudheesh.mavila@....com,
        "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Mario Limonciello <Mario.Limonciello@....com>
Subject: Re: [PATCH v3 1/9] kernel/resource: Introduce
 request_muxed_mem_region()



On 1/20/22 5:16 AM, Andy Shevchenko wrote:
> On Thu, Jan 20, 2022 at 1:06 AM Terry Bowman <terry.bowman@....com> wrote:
>>
>> Support for requesting muxed memory region is implemented but not
>> currently callable as a macro. Add the request muxed memory
>> region macro.
>>
>> MMIO memory accesses can be synchronized using request_mem_region() which
>> is already available. This call will return failure if the resource is
>> busy. The 'muxed' version of this macro will handle a busy resource by
>> using a wait queue to retry until the resource is available.
> 
> ...
> 
>> @@ -262,6 +262,8 @@ resource_union(struct resource *r1, struct resource *r2, struct resource *r)
>>  #define request_muxed_region(start,n,name)     __request_region(&ioport_resource, (start), (n), (name), IORESOURCE_MUXED)
>>  #define __request_mem_region(start,n,name, excl) __request_region(&iomem_resource, (start), (n), (name), excl)
>>  #define request_mem_region(start,n,name) __request_region(&iomem_resource, (start), (n), (name), 0)
> 
>> +#define request_muxed_mem_region(start, n, name) \
>> +       __request_region(&iomem_resource, (start), (n), (name), IORESOURCE_MUXED)
> 
> Looking around tells me that this name is inconsistent, I would expect it to be
> 
> request_mem_region_muxed()
> 
>>  #define request_mem_region_exclusive(start,n,name) \
>>         __request_region(&iomem_resource, (start), (n), (name), IORESOURCE_EXCLUSIVE)
> 
> If you are fine with this, take my
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
                                                                      
I'm fine with the rename. I'll update as you requested in the next series
revision and add your "reviewed-by" to this patch.

Regards,
Terry