linux-kernel - RE: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <016c01d80e05$1ef9eab0$5cedc010$@samsung.com>
Date:   Thu, 20 Jan 2022 19:23:31 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Stephen Boyd'" <sboyd@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Cc:     <soc@...nel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <olof@...om.net>, <arnd@...db.de>,
        <linus.walleij@...aro.org>, <catalin.marinas@....com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski@...onical.com>,
        <s.nawrocki@...sung.com>, <linux-samsung-soc@...r.kernel.org>,
        <pankaj.dubey@...sung.com>, <linux-fsd@...la.com>,
        "'Jayati Sahu'" <jayati.sahu@...sung.com>,
        "'Ajay Kumar'" <ajaykumar.rs@...sung.com>
Subject: RE: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support

Hi Stephen

>-----Original Message-----
>From: Stephen Boyd [mailto:sboyd@...nel.org]
>Sent: Thursday, January 20, 2022 1:45 AM
>To: Alim Akhtar <alim.akhtar@...sung.com>; linux-arm-
>kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
>Cc: soc@...nel.org; linux-clk@...r.kernel.org; devicetree@...r.kernel.org;
>olof@...om.net; arnd@...db.de; linus.walleij@...aro.org;
>catalin.marinas@....com; robh+dt@...nel.org;
>krzysztof.kozlowski@...onical.com; s.nawrocki@...sung.com; linux-
>samsung-soc@...r.kernel.org; pankaj.dubey@...sung.com; Alim Akhtar
><alim.akhtar@...sung.com>; linux-fsd@...la.com; Jayati Sahu
><jayati.sahu@...sung.com>; Ajay Kumar <ajaykumar.rs@...sung.com>
>Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support
>
>Quoting Alim Akhtar (2022-01-18 06:48:39)
>> diff --git a/drivers/clk/samsung/clk-fsd.c
>> b/drivers/clk/samsung/clk-fsd.c new file mode 100644 index
>> 000000000000..2669396d81b9
>> --- /dev/null
>> +++ b/drivers/clk/samsung/clk-fsd.c
>> @@ -0,0 +1,308 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd.
>> + *             https://www.samsung.com
>> + * Copyright (c) 2017-2022 Tesla, Inc.
>> + *             https://www.tesla.com
>> + *
>> + * Common Clock Framework support for FSD SoC.
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/of.h>
>
>include init.h for __initconst and kernel.h for ARRAY_SIZE
>
I did not face any compilation error.
Do I need to explicitly add these header files in driver? I see clk.h implicitly includes kernel.h
Same is the case of other driver in this directory.

>> +
>> +#include <dt-bindings/clock/fsd-clk.h>
>> +
>> +#include "clk.h"
>> +