linux-kernel - Re: [GIT PULL] Bitmap patches for 5.17-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whc9DAJN-TWPTnw=bSjHwXk1zDGeJ9A8eniaK7Jfax5aQ@mail.gmail.com>
Date:   Thu, 20 Jan 2022 17:53:00 +0200
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Yury Norov <yury.norov@...il.com>
Cc:     Alexey Klimov <aklimov@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Lobakin <alobakin@...me>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dennis Zhou <dennis@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
        linux-mm <linux-mm@...ck.org>, mm-commits@...r.kernel.org,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Will Deacon <will@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Bitmap patches for 5.17-rc1

On Sat, Jan 15, 2022 at 7:10 PM Yury Norov <yury.norov@...il.com> wrote:
>
> bitmap patches for 5.17-rc1
>
> Hi Linus, please pull these patches for bitmap. They were supposed to
> be pulled in 5.16 cycle, but due to merge glitch we decided to merge them
> in 5.17.

So I'm looking at this pull request that changes quite a bit of random
files, and some rather core headers, and I see *no* actual explanation
for what this pull request does and why I should pull it.

Only a "we didn't do it last cycle, so we should do it now". That's
not much of an argument.  If anything, it makes me go "there was
something wrong with it last time".

I can look at the commits (and I did), but that's really not how this
is all supposed to work.

When I _do_ look at the commits, one thing that stands out is how this
was all appears to be rebased after the merge window opened (just
minutes before you sent the pull request, I suspect).

Which is *also* not how things are supposed to work.

I also don't have your pgp key (not your fault - pgp key distribution
is broken because keyservers are broken) and I haven't pulled from you
before. That all just makes this pull request something where I think
it's all likely good, but there are enough problems that I haven't
actually pulled it.

Put another way: the contents do not appear _wrong_ per se, but there
are many things in this pull request that keep me from actually doing
the pull..

                   Linus