linux-kernel - Re: [PATCH 2/2] psi: Fix "defined but not used" warnings when CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YemFypC3TKwpuUvm@cmpxchg.org>
Date:   Thu, 20 Jan 2022 10:54:50 -0500
From:   Johannes Weiner <hannes@...xchg.org>
To:     Suren Baghdasaryan <surenb@...gle.com>
Cc:     peterz@...radead.org, mingo@...hat.com, ebiggers@...nel.org,
        tj@...nel.org, willy@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 2/2] psi: Fix "defined but not used" warnings when
 CONFIG_PROC_FS=n

On Wed, Jan 19, 2022 at 02:39:40PM -0800, Suren Baghdasaryan wrote:
> When CONFIG_PROC_FS is disabled psi code generates the following warnings:
> 
> kernel/sched/psi.c:1364:30: warning: 'psi_cpu_proc_ops' defined but not used [-Wunused-const-variable=]
>     1364 | static const struct proc_ops psi_cpu_proc_ops = {
>          |                              ^~~~~~~~~~~~~~~~
> kernel/sched/psi.c:1355:30: warning: 'psi_memory_proc_ops' defined but not used [-Wunused-const-variable=]
>     1355 | static const struct proc_ops psi_memory_proc_ops = {
>          |                              ^~~~~~~~~~~~~~~~~~~
> kernel/sched/psi.c:1346:30: warning: 'psi_io_proc_ops' defined but not used [-Wunused-const-variable=]
>     1346 | static const struct proc_ops psi_io_proc_ops = {
>          |                              ^~~~~~~~~~~~~~~
> 
> Make definitions of these structures and related functions conditional on
> CONFIG_PROC_FS config.
> 
> Fixes: 0e94682b73bf ("psi: introduce psi monitor")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>

Acked-by: Johannes Weiner <hannes@...xchg.org>