linux-kernel - Re: [PATCH v2 8/9] regulator/rpi-panel-attiny: Don't read the LCD power status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yerfr8Nj43TTPcAF@sirena.org.uk>
Date:   Fri, 21 Jan 2022 16:30:39 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Detlev Casanova <detlev.casanova@...labora.com>
Cc:     linux-kernel@...r.kernel.org,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v2 8/9] regulator/rpi-panel-attiny: Don't read the LCD
 power status

On Fri, Jan 21, 2022 at 10:20:55AM -0500, Detlev Casanova wrote:
> From: Dave Stevenson <dave.stevenson@...pberrypi.com>
> 
> The I2C to the Atmel is very fussy, and locks up easily on
> Pi0-3 particularly on reads.
> 
> The LCD power status is controlled solely by this driver, so
> rather than reading it back from the Atmel, use the cached
> status last set.

If that's the case since you're using regmap would it not make sense to
enable caching in order to minimise reads in general.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)