linux-kernel - Re: [PATCH 19/31] net: realtek: changing LED_* from enum led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jan 2022 17:12:40 +0000 (UTC)
From:   Hin-Tak Leung <htl10@...rs.sourceforge.net>
To:     Luiz Sampaio <sampaio.ime@...il.com>,
        Herton Ronaldo Krzesinski <herton@...onical.com>,
        Hin-Tak Leung <htl10@...rs.sourceforge.net>,
        Larry Finger <larry.finger@...inger.net>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Luiz Sampaio <sampaio.ime@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 19/31] net: realtek: changing LED_* from enum
 led_brightness to actual value

> -        if (brightness == LED_FULL) {
> +        if (brightness == 255) {

> -        if (brightness == LED_OFF) {
> +        if (brightness == 0) {

NAKed. I haven't received the other 30 patches in this series so I don't know the full context, but I don't think replacing meaningful enum names with numerical values is an improvement. If the ENUMs are gone from a common include (and why is the ENUM removed, if drivers use them??), and the realtek driver still have such a functionality, it probably should be defined in one of the rtl818*.h as RTL818X_LED_FULL and RTL818X_LED_OFF .

My $0.02, based on this one only of the 31.

Regards,
Hin-Tak