linux-kernel - Re: [PATCH] ipv4: fix lock leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BDEF9CF1-016A-48F2-A4F3-8B39CC219B4F@gmail.com>
Date:   Fri, 21 Jan 2022 12:06:06 +0800
From:   Ryan Cai <ycaibb@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <edumazet@...gle.com>, <davem@...emloft.net>,
        <yoshfuji@...ux-ipv6.org>, <dsahern@...nel.org>, <ast@...nel.org>,
        <daniel@...earbox.net>, <andrii@...nel.org>, <kafai@...com>,
        <songliubraving@...com>, <yhs@...com>, <john.fastabend@...il.com>,
        <kpsingh@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [PATCH] ipv4: fix lock leaks

Sorry for reporting this false positive. Would be more careful next time. Thank you for your checking.

Best,
Ryan

On 21/1/2022, 11:47 AM, "Jakub Kicinski" <kuba@...nel.org> wrote:

    On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
    >  			if (seq_sk_match(seq, sk))
    > +				spin_unlock_bh(lock);
    >  				return sk;

    Heh, also you're missing brackets so this is patently buggy.