linux-kernel - Re: [PATCH v2 3/3] arm64: dts: fsd: Add SPI device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Jan 2022 12:42:33 +0200
From:   Andi Shyti <andi@...zian.org>
To:     Alim Akhtar <alim.akhtar@...sung.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linus.walleij@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski@...onical.com,
        linux-samsung-soc@...r.kernel.org, pankaj.dubey@...sung.com,
        broonie@...nel.org, andi@...zian.org, linux-spi@...r.kernel.org,
        Aswani Reddy <aswani.reddy@...sung.com>, linux-fsd@...la.com
Subject: Re: [PATCH v2 3/3] arm64: dts: fsd: Add SPI device nodes

Hi Alim and Aswani,

On Fri, Jan 21, 2022 at 12:54:38AM +0530, Alim Akhtar wrote:
> From: Aswani Reddy <aswani.reddy@...sung.com>
> 
> Adds device tree node for SPI IPs
> 
> Cc: linux-fsd@...la.com
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Signed-off-by: Aswani Reddy <aswani.reddy@...sung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>

Reviewed-by: Andi Shyti <andi@...zian.org>

Please, also allow me another nit-commnent for the next patches:
the tag section is in chronological order. I suppose that first
Aswani wrote the patch, then you sent it to the mailing list and
at the end Krzysztof has reviewed it, this means that the right
order is:

  Signed-off-by: Aswani Reddy <aswani.reddy@...sung.com>
  Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
  Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Thank you,
Andi