linux-kernel - Re: [PATCH v2 2/3] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Jan 2022 12:32:30 +0200
From:   Andi Shyti <andi@...zian.org>
To:     Alim Akhtar <alim.akhtar@...sung.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linus.walleij@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski@...onical.com,
        linux-samsung-soc@...r.kernel.org, pankaj.dubey@...sung.com,
        broonie@...nel.org, andi@...zian.org, linux-spi@...r.kernel.org,
        linux-fsd@...la.com, Aswani Reddy <aswani.reddy@...sung.com>
Subject: Re: [PATCH v2 2/3] spi: s3c64xx: Add spi port configuration for
 Tesla FSD SoC

Hi Alim,

> Adds compatible and port configuration for spi controller
> for Tesla Full Self-Driving SoC.

please next time be a bit clearer in the cover letter. I think
you want to say:

  "This patch adds the compatible..."

But it's anyway recommended to use the imperative form:

  "Add the compatible blah blah blah...."

> Cc: linux-fsd@...la.com
> Signed-off-by: Aswani Reddy <aswani.reddy@...sung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>

Other than that, looks good to me:

Reviewed-by: Andi Shyti <andi@...zian.org>

Thanks,
Andi