linux-kernel - Re: [PATCH v2] mm/damon: Remove redundant page validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdc7a556-b826-8d82-91b-8664f8a655e@google.com>
Date:   Mon, 24 Jan 2022 10:20:20 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>
cc:     sj@...nel.org, akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation

On Mon, 17 Jan 2022, Baolin Wang wrote:

> It will never get a NULL page by pte_page() as discussed in thread [1],
> thus remove the redundant page validation to fix below Smatch static
> checker warning.
> 
>     mm/damon/vaddr.c:405 damon_hugetlb_mkold()
>     warn: 'page' can't be NULL.
> 
> [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> Reviewed-by: SeongJae Park <sj@...nel.org>

Acked-by: David Rientjes <rientjes@...gle.com>