linux-kernel - Re: [PATCH v2] mm/damon: Remove redundant page validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zbN9M5wFUzLAkH3k3Wrk1Byyyh-JTDqhb5AKca0jS5vBg@mail.gmail.com>
Date:   Tue, 25 Jan 2022 08:39:10 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     David Rientjes <rientjes@...gle.com>
Cc:     Baolin Wang <baolin.wang@...ux.alibaba.com>, sj@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux-MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation

On Mon, Jan 24, 2022 at 11:50 PM David Rientjes <rientjes@...gle.com> wrote:
>
> On Mon, 17 Jan 2022, Baolin Wang wrote:
>
> > It will never get a NULL page by pte_page() as discussed in thread [1],
> > thus remove the redundant page validation to fix below Smatch static
> > checker warning.
> >
> >     mm/damon/vaddr.c:405 damon_hugetlb_mkold()
> >     warn: 'page' can't be NULL.
> >
> > [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/
> >
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> > Reviewed-by: SeongJae Park <sj@...nel.org>
>
> Acked-by: David Rientjes <rientjes@...gle.com>

Acked-by: Souptick Joarder <jrdr.linux@...il.com>

>