linux-kernel - Re: [PATCH v3 1/2] fsi: sbefifo: Use specified value of start of response timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44deb918-2527-7fcd-29de-f09534b0837b@linux.ibm.com>
Date:   Mon, 24 Jan 2022 08:17:51 -0600
From:   Eddie James <eajames@...ux.ibm.com>
To:     Joel Stanley <joel@....id.au>, Jeremy Kerr <jk@...abs.org>,
        Alistar Popple <alistair@...ple.id.au>,
        Amitay Isaacs <amitay@...abs.org>
Cc:     linux-fsi@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] fsi: sbefifo: Use specified value of start of
 response timeout


On 1/20/22 23:38, Joel Stanley wrote:
> From: Amitay Isaacs <amitay@...abs.org>
>
> For some of the chip-ops where sbe needs to collect trace information,
> sbe can take a long time (>30s) to respond.  Currently these chip-ops
> will timeout as the start of response timeout defaults to 10s.
>
> Instead of default value, use specified value.  The require timeout
> value will be set using ioctl.


Reviewed-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Amitay Isaacs <amitay@...abs.org>
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>   drivers/fsi/fsi-sbefifo.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 52328adef643..1e9b326e8f67 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -125,6 +125,7 @@ struct sbefifo {
>   	bool			dead;
>   	bool			async_ffdc;
>   	bool			timed_out;
> +	u32			timeout_start_rsp_ms;
>   };
>   
>   struct sbefifo_user {
> @@ -549,7 +550,7 @@ static int sbefifo_read_response(struct sbefifo *sbefifo, struct iov_iter *respo
>   
>   	dev_vdbg(dev, "reading response, buflen = %zd\n", iov_iter_count(response));
>   
> -	timeout = msecs_to_jiffies(SBEFIFO_TIMEOUT_START_RSP);
> +	timeout = msecs_to_jiffies(sbefifo->timeout_start_rsp_ms);
>   	for (;;) {
>   		/* Grab FIFO status (this will handle parity errors) */
>   		rc = sbefifo_wait(sbefifo, false, &status, timeout);
> @@ -972,6 +973,7 @@ static int sbefifo_probe(struct device *dev)
>   	sbefifo->fsi_dev = fsi_dev;
>   	dev_set_drvdata(dev, sbefifo);
>   	mutex_init(&sbefifo->lock);
> +	sbefifo->timeout_start_rsp_ms = SBEFIFO_TIMEOUT_START_RSP;
>   
>   	/*
>   	 * Try cleaning up the FIFO. If this fails, we still register the