linux-kernel - Re: [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee85e10c-deb6-5173-0b2e-20226e2d6e8b@redhat.com>
Date:   Mon, 24 Jan 2022 15:18:09 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Quanfa Fu <quanfafu@...il.com>, seanjc@...gle.com,
        vkuznets@...hat.com, wanpengli@...cent.com, jmattson@...gle.com,
        joro@...tes.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static

On 12/19/21 10:14, Quanfa Fu wrote:
> Make kvm_vcpu_reload_apic_access_page() static
> as it is no longer invoked directly by vmx
> and it is also no longer exported.
> 
> No functional change intended.
> 
> Signed-off-by: Quanfa Fu <quanfafu@...il.com>
> ---
>   arch/x86/include/asm/kvm_host.h | 1 -
>   arch/x86/kvm/x86.c              | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 2164b9f4c7b0..f1c4ba208ed6 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1855,7 +1855,6 @@ int kvm_cpu_has_extint(struct kvm_vcpu *v);
>   int kvm_arch_interrupt_allowed(struct kvm_vcpu *vcpu);
>   int kvm_cpu_get_interrupt(struct kvm_vcpu *v);
>   void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event);
> -void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu);
>   
>   int kvm_pv_send_ipi(struct kvm *kvm, unsigned long ipi_bitmap_low,
>   		    unsigned long ipi_bitmap_high, u32 min,
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 0cf1082455df..6569a62ea38b 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -9621,7 +9621,7 @@ void kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm,
>   		kvm_make_all_cpus_request(kvm, KVM_REQ_APIC_PAGE_RELOAD);
>   }
>   
> -void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> +static void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
>   {
>   	if (!lapic_in_kernel(vcpu))
>   		return;

Queued, thanks.

paolo