linux-kernel - Re: [PATCH 01/60] drm/komeda: Add support for the nomodeset kernel parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d7a6077-9a44-1f8b-9e65-3bb7ed94523e@foss.arm.com>
Date:   Mon, 24 Jan 2022 17:09:57 +0000
From:   Carsten Haitzler <carsten.haitzler@...s.arm.com>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     Liviu Dudau <liviu.dudau@....com>,
        "James (Qian) Wang" <james.qian.wang@....com>
Subject: Re: [PATCH 01/60] drm/komeda: Add support for the nomodeset kernel
 parameter

Seems fine.

Reviewed-by: Carsten Haitzler <carsten.haitzler@....com>

On 12/15/21 00:59, Javier Martinez Canillas wrote:
> According to disable Documentation/admin-guide/kernel-parameters.txt, this
> parameter can be used to disable kernel modesetting.
> 
> DRM drivers will not perform display-mode changes or accelerated rendering
> and only the systewm system framebuffer will be available if it was set-up.
> 
> But only a few DRM drivers currently check for nomodeset, make this driver
> to also support the command line parameter.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
> 
>   drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index e7933930a657..4f6d5c2103ec 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -9,6 +9,7 @@
>   #include <linux/platform_device.h>
>   #include <linux/component.h>
>   #include <linux/pm_runtime.h>
> +#include <drm/drm_drv.h>
>   #include <drm/drm_of.h>
>   #include "komeda_dev.h"
>   #include "komeda_kms.h"
> @@ -117,6 +118,9 @@ static int komeda_platform_probe(struct platform_device *pdev)
>   	struct component_match *match = NULL;
>   	struct device_node *child;
>   
> +	if (drm_firmware_drivers_only())
> +		return -EINVAL;
> +
>   	if (!dev->of_node)
>   		return -ENODEV;
>