linux-kernel - Re: [PATCH 02/60] drm/arm/hdlcd: Add support for the nomodeset kernel parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d9d0ead-f828-1e8a-b7cd-3ad50213c6bd@foss.arm.com>
Date:   Mon, 24 Jan 2022 17:09:55 +0000
From:   Carsten Haitzler <carsten.haitzler@...s.arm.com>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     Liviu Dudau <liviu.dudau@....com>
Subject: Re: [PATCH 02/60] drm/arm/hdlcd: Add support for the nomodeset kernel
 parameter

Seems fine.

Reviewed-by: Carsten Haitzler <carsten.haitzler@....com>

On 12/15/21 00:59, Javier Martinez Canillas wrote:
> According to disable Documentation/admin-guide/kernel-parameters.txt, this
> parameter can be used to disable kernel modesetting.
> 
> DRM drivers will not perform display-mode changes or accelerated rendering
> and only the systewm system framebuffer will be available if it was set-up.
> 
> But only a few DRM drivers currently check for nomodeset, make this driver
> to also support the command line parameter.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
> 
>   drivers/gpu/drm/arm/hdlcd_drv.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index 479c2422a2e0..0939a64a9bd2 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -382,6 +382,9 @@ static int hdlcd_probe(struct platform_device *pdev)
>   	struct device_node *port;
>   	struct component_match *match = NULL;
>   
> +	if (drm_firmware_drivers_only())
> +		return -ENODEV;
> +
>   	/* there is only one output port inside each device, find it */
>   	port = of_graph_get_remote_node(pdev->dev.of_node, 0, 0);
>   	if (!port)