linux-kernel - Re: [PATCH] ieee80211: cleanup double word in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65cbae9c-20dc-6fab-a462-b74468b9303e@redhat.com>
Date:   Tue, 25 Jan 2022 12:03:50 -0800
From:   Tom Rix <trix@...hat.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ieee80211: cleanup double word in comment


On 1/25/22 10:19 AM, Johannes Berg wrote:
> On Tue, 2022-01-25 at 10:07 -0800, trix@...hat.com wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> Remove the second 'that'.
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
>> ---
>>   include/linux/ieee80211.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
>> index 559b6c6449384..5475383936f8b 100644
>> --- a/include/linux/ieee80211.h
>> +++ b/include/linux/ieee80211.h
>> @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
>>   static inline bool ieee80211_is_data_present(__le16 fc)
>>   {
>>   	/*
>> -	 * mask with 0x40 and test that that bit is clear to only return true
>> +	 * mask with 0x40 and test that bit is clear to only return true
>>   	 * for the data-containing substypes.
>>
> I don't think it's just a duplicate?
>
> ... and (test that) (that bit is clear to ...)
>
> no?

ok, reads ok.

Sorry for the noise.

T

>
> johannes
>