linux-kernel - Re: [PATCH] ieee80211: cleanup double word in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <441d593f4c55e15913cd72710d0b196361484ce0.camel@perches.com>
Date:   Tue, 25 Jan 2022 10:30:29 -0800
From:   Joe Perches <joe@...ches.com>
To:     trix@...hat.com, johannes@...solutions.net
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ieee80211: cleanup double word in comment

On Tue, 2022-01-25 at 10:07 -0800, trix@...hat.com wrote:
> Remove the second 'that'.
[]
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
[]
> @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
>  static inline bool ieee80211_is_data_present(__le16 fc)
>  {
>  	/*
> -	 * mask with 0x40 and test that that bit is clear to only return true
> +	 * mask with 0x40 and test that bit is clear to only return true

This is likely a false positive...

"that that" is  frequently correct usage.
"that the" might be acceptable here instead.

Not sure about the "only" use though.
Maybe fix the substypes typo too.

---
 include/linux/ieee80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index 559b6c6449384..0d9864adf9911 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -467,8 +467,8 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
 static inline bool ieee80211_is_data_present(__le16 fc)
 {
 	/*
-	 * mask with 0x40 and test that that bit is clear to only return true
-	 * for the data-containing substypes.
+	 * mask with 0x40 and test that the bit is clear to return true
+	 * only for the data-containing subtypes.
 	 */
 	return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | 0x40)) ==
 	       cpu_to_le16(IEEE80211_FTYPE_DATA);