linux-kernel - Re: [PATCH] btrfs: initialize variable cancel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220124194910.GF14046@twin.jikos.cz>
Date:   Mon, 24 Jan 2022 20:49:10 +0100
From:   David Sterba <dsterba@...e.cz>
To:     trix@...hat.com
Cc:     clm@...com, josef@...icpanda.com, dsterba@...e.com,
        nathan@...nel.org, ndesaulniers@...gle.com, anand.jain@...cle.com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] btrfs: initialize variable cancel

On Fri, Jan 21, 2022 at 05:45:22AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this problem
> ioctl.c:3333:8: warning: 3rd function call argument is an
>   uninitialized value
>     ret = exclop_start_or_cancel_reloc(fs_info,
> 
> cancel is only set in one branch of an if-check and is
> always used.  So initialize to false.
> 
> Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
> Signed-off-by: Tom Rix <trix@...hat.com>

Added to misc-next, with the updted subject line, thanks.