linux-kernel - Re: [PATCH] include: linux: Reorganize timekeeping and ktime headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202201270546.CQtmCsGw-lkp@intel.com>
Date:   Thu, 27 Jan 2022 05:25:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Carlos Bilbao <carlos.bilbao@....com>, john.stultz@...aro.org,
        tglx@...utronix.de
Cc:     kbuild-all@...ts.01.org, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org, sboyd@...nel.org,
        linux-arm-kernel@...ts.infradead.org, rostedt@...dmis.org,
        boon.leong.ong@...el.com, mhiramat@...nel.org, bilbao@...edu
Subject: Re: [PATCH] include: linux: Reorganize timekeeping and ktime headers

Hi Carlos,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on geert-m68k/for-next]
[also build test WARNING on tip/timers/core tip/x86/core linus/master v5.17-rc1 next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20220127-041038
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git for-next
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220127/202201270546.CQtmCsGw-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3c432f5cbb3c550c1cef6747c4281b65a7d9d708
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20220127-041038
        git checkout 3c432f5cbb3c550c1cef6747c4281b65a7d9d708
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash arch/m68k/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/m68k/kernel/time.c:67:6: warning: no previous prototype for 'read_persistent_clock64' [-Wmissing-prototypes]
      67 | void read_persistent_clock64(struct timespec64 *ts)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   arch/m68k/kernel/time.c:145:13: warning: no previous prototype for 'time_init' [-Wmissing-prototypes]
     145 | void __init time_init(void)
         |             ^~~~~~~~~


vim +/read_persistent_clock64 +67 arch/m68k/kernel/time.c

fa7f9e7fade8457 Greg Ungerer  2012-01-23  64  
065f109f2506d6b Arnd Bergmann 2018-04-23  65  #ifdef CONFIG_M68KCLASSIC
065f109f2506d6b Arnd Bergmann 2018-04-23  66  #if !IS_BUILTIN(CONFIG_RTC_DRV_GENERIC)
065f109f2506d6b Arnd Bergmann 2018-04-23 @67  void read_persistent_clock64(struct timespec64 *ts)
fa7f9e7fade8457 Greg Ungerer  2012-01-23  68  {
fa7f9e7fade8457 Greg Ungerer  2012-01-23  69  	struct rtc_time time;
b65769fc013edb7 Finn Thain    2018-04-23  70  
fa7f9e7fade8457 Greg Ungerer  2012-01-23  71  	ts->tv_sec = 0;
fa7f9e7fade8457 Greg Ungerer  2012-01-23  72  	ts->tv_nsec = 0;
fa7f9e7fade8457 Greg Ungerer  2012-01-23  73  
b65769fc013edb7 Finn Thain    2018-04-23  74  	if (!mach_hwclk)
b65769fc013edb7 Finn Thain    2018-04-23  75  		return;
b65769fc013edb7 Finn Thain    2018-04-23  76  
fa7f9e7fade8457 Greg Ungerer  2012-01-23  77  	mach_hwclk(0, &time);
fa7f9e7fade8457 Greg Ungerer  2012-01-23  78  
065f109f2506d6b Arnd Bergmann 2018-04-23  79  	ts->tv_sec = mktime64(time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
fa7f9e7fade8457 Greg Ungerer  2012-01-23  80  			      time.tm_hour, time.tm_min, time.tm_sec);
fa7f9e7fade8457 Greg Ungerer  2012-01-23  81  }
065f109f2506d6b Arnd Bergmann 2018-04-23  82  #endif
fa7f9e7fade8457 Greg Ungerer  2012-01-23  83  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org