linux-kernel - Re: [PATCH] include: linux: Reorganize timekeeping and ktime headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 06:47:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Carlos Bilbao <carlos.bilbao@....com>, john.stultz@...aro.org,
        tglx@...utronix.de
Cc:     kbuild-all@...ts.01.org, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org, sboyd@...nel.org,
        linux-arm-kernel@...ts.infradead.org, rostedt@...dmis.org,
        boon.leong.ong@...el.com, mhiramat@...nel.org, bilbao@...edu
Subject: Re: [PATCH] include: linux: Reorganize timekeeping and ktime headers

Hi Carlos,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on geert-m68k/for-next]
[also build test WARNING on tip/timers/core tip/x86/core linus/master v5.17-rc1 next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20220127-041038
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git for-next
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220127/202201270622.w96GBqWO-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3c432f5cbb3c550c1cef6747c4281b65a7d9d708
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20220127-041038
        git checkout 3c432f5cbb3c550c1cef6747c4281b65a7d9d708
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/um/kernel/time.c:763:6: warning: no previous prototype for 'read_persistent_clock64' [-Wmissing-prototypes]
     763 | void read_persistent_clock64(struct timespec64 *ts)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   arch/um/kernel/time.c:778:13: warning: no previous prototype for 'time_init' [-Wmissing-prototypes]
     778 | void __init time_init(void)
         |             ^~~~~~~~~


vim +/read_persistent_clock64 +763 arch/um/kernel/time.c

aceb343464a136e arch/um/kernel/time_kern.c Jeff Dike       2006-07-10  762  
288fb3d5683f508 arch/um/kernel/time.c      Arnd Bergmann   2017-11-02 @763  void read_persistent_clock64(struct timespec64 *ts)
9f31f5774961a73 arch/um/kernel/time.c      John Stultz     2010-07-13  764  {
065038706f77a56 arch/um/kernel/time.c      Johannes Berg   2019-05-27  765  	long long nsecs;
065038706f77a56 arch/um/kernel/time.c      Johannes Berg   2019-05-27  766  
7f3414226b58b0d arch/um/kernel/time.c      Johannes Berg   2021-01-15  767  	time_travel_set_start();
7f3414226b58b0d arch/um/kernel/time.c      Johannes Berg   2021-01-15  768  
2701c1bd91dda81 arch/um/kernel/time.c      Johannes Berg   2020-12-02  769  	if (time_travel_mode != TT_MODE_OFF)
065038706f77a56 arch/um/kernel/time.c      Johannes Berg   2019-05-27  770  		nsecs = time_travel_start + time_travel_time;
065038706f77a56 arch/um/kernel/time.c      Johannes Berg   2019-05-27  771  	else
065038706f77a56 arch/um/kernel/time.c      Johannes Berg   2019-05-27  772  		nsecs = os_persistent_clock_emulation();
b29230769e3482b arch/um/kernel/time.c      Thomas Gleixner 2010-08-03  773  
288fb3d5683f508 arch/um/kernel/time.c      Arnd Bergmann   2017-11-02  774  	set_normalized_timespec64(ts, nsecs / NSEC_PER_SEC,
9f31f5774961a73 arch/um/kernel/time.c      John Stultz     2010-07-13  775  				  nsecs % NSEC_PER_SEC);
9f31f5774961a73 arch/um/kernel/time.c      John Stultz     2010-07-13  776  }
9f31f5774961a73 arch/um/kernel/time.c      John Stultz     2010-07-13  777  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org