linux-kernel - [PATCH] IB/usnic: Fix memory leak in usnic_ib_sysfs_qpn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220126060425.11124-1-linmq006@gmail.com>
Date:   Wed, 26 Jan 2022 06:04:25 +0000
From:   Miaoqian Lin <linmq006@...il.com>
To:     Christian Benvenuti <benve@...co.com>,
        Nelson Escobar <neescoba@...co.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Upinder Malhi <umalhi@...co.com>,
        Roland Dreier <roland@...estorage.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     linmq006@...il.com
Subject: [PATCH] IB/usnic: Fix memory leak in usnic_ib_sysfs_qpn_add

kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()：

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix memory leak by calling kobject_put().

Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c b/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
index 7d868f033bbf..69c5854deebc 100644
--- a/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
@@ -280,6 +280,7 @@ void usnic_ib_sysfs_qpn_add(struct usnic_ib_qp_grp *qp_grp)
 			kobject_get(us_ibdev->qpn_kobj),
 			"%d", qp_grp->grp_id);
 	if (err) {
+		kobject_put(&qp_grp->kobj);
 		kobject_put(us_ibdev->qpn_kobj);
 		return;
 	}
-- 
2.17.1