linux-kernel - Re: [PATCH v4] integrity: check the return value of audit_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f87e6cef510013e3a7ce2ce31a444767650f9fdf.camel@linux.ibm.com>
Date:   Wed, 26 Jan 2022 21:19:08 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Xiaoke Wang <xkernel.wang@...mail.com>
Cc:     paul <paul@...l-moore.com>, jmorris <jmorris@...ei.org>,
        serge <serge@...lyn.com>,
        linux-integrity <linux-integrity@...r.kernel.org>,
        linux-security-module <linux-security-module@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] integrity: check the return value of
 audit_log_start()

Hi Xiaoke,

On Thu, 2022-01-27 at 09:59 +0800, Xiaoke Wang wrote:
> From: Xiaoke Wang <xkernel.wang@...mail.com>
> 
> audit_log_start() returns audit_buffer pointer on success or NULL on
> error, so it is better to check the return value of it.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>
> Reviewed-by: Paul Moore <paul@...l-moore.com>

Thanks, this patch is staged in the next-integrity-testing branch 
https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git/

Mimi