linux-kernel - [PATCH v4] integrity: check the return value of audit_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 09:59:05 +0800
From:   "Xiaoke Wang" <xkernel.wang@...mail.com>
To:     "Mimi Zohar" <zohar@...ux.ibm.com>
Cc:     "paul" <paul@...l-moore.com>,
        "jmorris" <jmorris@...ei.org>,
        "serge" <serge@...lyn.com>,
        "linux-integrity" 
        <linux-integrity@...r.kernel.org>,
        "linux-security-module" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: [PATCH v4] integrity: check the return value of audit_log_start()

From: Xiaoke Wang <xkernel.wang@...mail.com>

audit_log_start() returns audit_buffer pointer on success or NULL on
error, so it is better to check the return value of it.

Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>
Reviewed-by: Paul Moore <paul@...l-moore.com>
---
Changelogs:
V3 -> V4: update the mail list.
V2 -> V3: add the Reviewed-by tag.
V1 -> V2: simplify the patch.
security/integrity/integrity_audit.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c
index 2922005..0ec5e4c 100644
--- a/security/integrity/integrity_audit.c
+++ b/security/integrity/integrity_audit.c
@@ -45,6 +45,8 @@ void integrity_audit_message(int audit_msgno, struct inode *inode,
 		return;
 
 	ab = audit_log_start(audit_context(), GFP_KERNEL, audit_msgno);
+	if (!ab)
+		return;
 	audit_log_format(ab, "pid=%d uid=%u auid=%u ses=%u",
 			 task_pid_nr(current),
 			 from_kuid(&init_user_ns, current_uid()),
--