linux-kernel - Re: [PATCH 5/5] spi: make remove callback a void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrZQ0JUjNt_bcxLXVGZ6NtLdUktN7v_4fj--ntoO26TPg@mail.gmail.com>
Date:   Thu, 27 Jan 2022 12:39:22 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH 5/5] spi: make remove callback a void function

- To avoid spamming lists/people, I have dropped most of them from the
to/cc list

On Sun, 23 Jan 2022 at 18:54, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org> # For MMC

[...]

Kind regards
Uffe