linux-kernel - Re: [PATCH 5/5] spi: make remove callback a void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 14:41:30 +0100
From:   Marcus Folkesson <marcus.folkesson@...il.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     linux-iio@...r.kernel.og, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] spi: make remove callback a void function

On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-König wrote:
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
> 
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---


>  drivers/iio/adc/mcp3911.c                             |  4 +---
>  drivers/iio/dac/ltc1660.c                             |  4 +---

Acked-by: Marcus Folkesson <marcus.folkesson@...il.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)