linux-kernel - Re: [PATCH] ALSA: usb-audio: initialize variables that could ignore errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5ha6fhjnxx.wl-tiwai@suse.de>
Date:   Thu, 27 Jan 2022 14:41:30 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     trix@...hat.com
Cc:     perex@...ex.cz, tiwai@...e.com, nathan@...nel.org,
        ndesaulniers@...gle.com, kai.heng.feng@...onical.com,
        jiapeng.chong@...ux.alibaba.com, giun7a@...il.com,
        colin.king@...el.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] ALSA: usb-audio: initialize variables that could ignore errors

On Wed, 26 Jan 2022 19:21:42 +0100,
trix@...hat.com wrote:
> 
> From: Tom Rix <trix@...hat.com>
> 
> clang static analysis reports this representative issue
> mixer.c:1548:35: warning: Assigned value is garbage or undefined
>         ucontrol->value.integer.value[0] = val;
>                                          ^ ~~~
> 
> The filter_error() macro allows errors to be ignored.
> If errors can be ignored, initialize variables
> so garbage will not be used.
> 
> Fixes: 48cc42973509 ("ALSA: usb-audio: Filter error from connector kctl ops, too")
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks, applied.


Takashi