linux-kernel - Re: [PATCH] vchiq-mmal: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdbe3eaf-c737-0714-6b54-8a7cdbe38a0c@i2se.com>
Date:   Thu, 27 Jan 2022 13:35:09 +0100
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     cgel.zte@...il.com, nsaenz@...nel.org
Cc:     rdunlap@...radead.org, unixbhaskar@...il.com,
        dave.stevenson@...pberrypi.com,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

Hi,

Am 27.01.22 um 02:44 schrieb cgel.zte@...il.com:
> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>
>
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
are you sure that drain_workqueue() is the same as flush_workqueue()?
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>  drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> index 76d3f0399964..60305c63c6f6 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> @@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
>  	mutex_unlock(&instance->vchiq_mutex);
>  
>  	vchiq_shutdown(instance->vchiq_instance);
> -	flush_workqueue(instance->bulk_wq);
>  	destroy_workqueue(instance->bulk_wq);
>  
>  	vfree(instance->bulk_scratch);