linux-kernel - Re: [PATCH] vchiq-mmal: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220128070330.GD1951@kadam>
Date:   Fri, 28 Jan 2022 10:03:31 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     cgel.zte@...il.com, nsaenz@...nel.org, rdunlap@...radead.org,
        unixbhaskar@...il.com, dave.stevenson@...pberrypi.com,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
> Hi,
> 
> Am 27.01.22 um 02:44 schrieb cgel.zte@...il.com:
> > From: "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>
> >
> > 'destroy_workqueue()' already drains the queue before destroying it,
> > so there is no need to flush it explicitly.
> >
> > Remove the redundant 'flush_workqueue()' calls.
> are you sure that drain_workqueue() is the same as flush_workqueue()?

drain_workqueue() calls flush_workqueue() repeatedly.

regards,
dan carpenter