linux-kernel - Re: [ocfs2] c42ff46f97: sysctl_table_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjzWVW1xvVLCOvw-MMoVK9kiRn5CUx2am8jPdo09mHgjA@mail.gmail.com>
Date:   Fri, 28 Jan 2022 19:16:21 +0200
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Jan Kara <jack@...e.cz>, kernel test robot <oliver.sang@...el.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Amir Goldstein <amir73il@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Antti Palosaari <crope@....fi>, Arnd Bergmann <arnd@...db.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Benjamin LaHaise <bcrl@...ck.org>,
        Clemens Ladisch <clemens@...isch.de>,
        David Airlie <airlied@...ux.ie>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joel Becker <jlbec@...lplan.org>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        Kees Cook <keescook@...omium.org>,
        Lukas Middendorf <kernel@...force.de>,
        Mark Fasheh <mark@...heh.com>, Paul Turner <pjt@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Petr Mladek <pmladek@...e.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Qing Wang <wangqing@...o.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Sebastian Reichel <sre@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Stephen Kitt <steve@....org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Xiaoming Ni <nixiaoming@...wei.com>,
        Douglas Gilbert <dgilbert@...erlog.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Jani Nikula <jani.nikula@...el.com>,
        John Ogness <john.ogness@...utronix.de>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Suren Baghdasaryan <surenb@...gle.com>,
        "Theodore Ts'o" <tytso@....edu>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [ocfs2] c42ff46f97: sysctl_table_check_failed

On Fri, Jan 28, 2022 at 6:49 PM Eric W. Biederman <ebiederm@...ssion.com> wrote:
>
> Yes.  There is a register_sysctl_paths that can be used if you want/need
> the embedded directories.  That probably would have been a better
> choice for an automated conversion.
>
> But since this there is only the single file in a single directory
> register_sysctl() with the full path is perfectly fine in this case.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com>

I was doing filesystem pull requests anyway, and as a result (I tend
to group things by topic if there's multiple things pending) I already
committed that patch of mine based on Jan's reviewed/tested-by, so
this reviewed-by ended up not in the tree.

But maybe somebody should check the other automated conversions for
the same issue? Hint hint.

Also, I'm somewhat unhappy about the fact that apparently the kernel
test robot already found this issue back in November of last year, yet
it made it to mainline several months later without being fixed.

It's hard to tell from this link:

  https://lists.01.org/hyperkitty/list/lkp@lists.01.org/thread/KQ2F6TPJWMDVEXJM4WTUC4DU3EH3YJVT/

but it does look like that original report only made it to that lkp
list and not the actual people listed on the commit itself? That would
explain why the report was overlooked.

Kind of sad.

              Linus