linux-kernel - Re: [PATCH v3] kselftest: Fix vdso_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25eb270c-fa11-f2bc-0686-b5a8c55cd0a7@linuxfoundation.org>
Date:   Fri, 28 Jan 2022 10:41:03 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Cristian Marussi <cristian.marussi@....com>,
        Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] kselftest: Fix vdso_test_abi return status

On 1/28/22 10:35 AM, Shuah Khan wrote:
> On 1/28/22 7:44 AM, Cristian Marussi wrote:
>> On Fri, Jan 28, 2022 at 01:07:01PM +0000, Vincenzo Frascino wrote:
>>> vdso_test_abi contains a batch of tests that verify the validity of the
>>> vDSO ABI.
>>>
>>> When a vDSO symbol is not found the relevant test is skipped reporting
>>> KSFT_SKIP. All the tests return values are then added in a single
>>> variable which is checked to verify failures. This approach can have
>>> side effects which result in reporting the wrong kselftest exit status.
>>>
>>> Fix vdso_test_abi verifying the return code of each test separately.
>>>
>>> Cc: Shuah Khan <shuah@...nel.org>
>>> Cc: Andy Lutomirski <luto@...nel.org>
>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>> Reported-by: Cristian Marussi <cristian.marussi@....com>
>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
>>> ---
>>
>> Hi,
>>
>> LGTM.
>>
>> Tested-by: Cristian Marussi <cristian.marussi@....com>
>>
>> Thanks,
>> Cristian
> 
> Thank you both. Will queue this up for 5.17 rc3.
> 

Vincenzo,

A couple of checkpatch warns. Please fix them and send me v4.

thanks,
-- Shuah