linux-kernel - Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0adde369-3fd7-3608-594c-d199cce3c936@redhat.com>
Date:   Fri, 28 Jan 2022 09:59:54 -0800
From:   Tom Rix <trix@...hat.com>
To:     Bart Van Assche <bvanassche@....org>, kashyap.desai@...adcom.com,
        sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, nathan@...nel.org,
        ndesaulniers@...gle.com
Cc:     megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid


On 1/28/22 9:42 AM, Bart Van Assche wrote:
> On 1/27/22 07:19, trix@...hat.com wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> checkpatch reports several hundred formatting errors.
>> Run these files through clang-format and knock off
>> some of them.
>
> Isn't this the kind of patches that carries more risk than value? 
> Additionally, this patch conflicts with a patch series that I plan to 
> post soon.
>
> Thanks,

I have dropped this patch.

Long term, it would be good have a reliable way to automatically fix 
either new files or really broken old files.

So you could do two patches, first would be fixing formatting problems 
and second would new stuff.

As it is your new patch will have to both for now.

Tom

>
>
> Bart.
>