linux-kernel - Re: [PATCH] memcg: replace in_interrupt() with !in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALvZod4Tg8VAPOYriNfQAdW1TM1vf9rQu+7N6jc0Mod096RFCA@mail.gmail.com>
Date:   Fri, 28 Jan 2022 08:20:04 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Vasily Averin <vvs@...tuozzo.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Roman Gushchin <guro@...com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memcg: replace in_interrupt() with !in_task()

On Fri, Jan 28, 2022 at 4:23 AM Michal Hocko <mhocko@...e.com> wrote:
>
> On Thu 27-01-22 08:26:36, Shakeel Butt wrote:
> > Replace the deprecated in_interrupt() with !in_task() because
> > in_interrupt() returns true for BH disabled even if the call happens in
> > the task context. in_task() is the right interface to differentiate
> > task context from NMI, hard IRQ and softirq contexts.
>
> Makes sense. I do not think this will have any visible effect. Except
> for removing a deprecated call, right?

Correct, that is my understanding as well.