linux-kernel - Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3707328ca9cbad0ecc0adb5d6df95e671b0f9270.camel@perches.com>
Date:   Fri, 28 Jan 2022 08:23:28 -0800
From:   Joe Perches <joe@...ches.com>
To:     Tom Rix <trix@...hat.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Finn Thain <fthain@...ux-m68k.org>,
        Miguel Ojeda <ojeda@...nel.org>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     kashyap.desai@...adcom.com, sumit.saxena@...adcom.com,
        shivasharan.srikanteshwara@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, nathan@...nel.org,
        megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

(adding checkpatch reviewers Dwaipayan and Lukas)

Original thread: https://lore.kernel.org/lkml/20220127151945.1244439-1-trix@redhat.com/

On Fri, 2022-01-28 at 07:30 -0800, Tom Rix wrote:
> On 1/28/22 12:41 AM, Joe Perches wrote:
> > Another option would be to use:
> > 
> > 	./scripts/checkpatch.pl -f --fix[-inplace] [--types=<list>] <files>
> > 
> > where types is an optional list of specific things to change
> > 
> > see:
> > 	./scripts/checkpatch.pl --list-types --verbose
> > 
> > to show the possible types.
> > 
> > Only some of these types can be changed with --fix or --fix-inplace
> > 
> > If using checkpatch to change formatting, it sometimes can be useful
> > to run checkpatch --fix multiple times on the same file as a
> > checkpatch --fix can create a change than checkpatch will suggest
> > should itself be fixed.
> > 
> > Of course another option is to do nothing as many will complain,
> > sometimes senselessly, about 'churn'.
> 
> A testsuite for the fixers may help with churn

Likely not, as IMO churn is an 'eye of beholder' issue.

> Any interest or thought on organization ?

Not really.

The checkpatch --fix code isn't perfect as it's just regexes.

When writing the --fix code, I've always just used the kernel
sources and git history to inspect/verify suggested changes.  

> I can take stab at one.

Enjoy.