linux-kernel - Re: [PATCH] x86/cpufeatures: Move the definition of X86_FEATURE_AMX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfVM+xdDS76E3d6r@zn.tnic>
Date:   Sat, 29 Jan 2022 15:19:39 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Like Xu <like.xu.linux@...il.com>
Cc:     Dave Hansen <dave.hansen@...el.com>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Jing Liu <jing2.liu@...el.com>, linux-kernel@...r.kernel.org,
        "Bae, Chang Seok" <chang.seok.bae@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/cpufeatures: Move the definition of
 X86_FEATURE_AMX_* to the word 18

On Wed, Jan 19, 2022 at 11:41:31AM +0800, Like Xu wrote:
> Thanks Dave and Paolo.  Just for your convenience:
> 
> From 588c2221999c1f5860188a7cbaeb0d4f80c6d727 Mon Sep 17 00:00:00 2001
> From: Like Xu <likexu@...cent.com>
> Date: Mon, 17 Jan 2022 14:23:44 +0800
> Subject: [PATCH v2] x86/cpufeatures: Move AMX CPU feature defines to correct
>  word location
> 
> From: Like Xu <likexu@...cent.com>
> 
> The word 18 for Intel-defined CPU features from CPUID level 0x00000007:0 (EDX)
> has been defined in the same file. Move the definitions of X86_FEATURE_AMX_* to
> the right entry to prevent misinterpretation. No functional change intended.
> 
> Signed-off-by: Like Xu <likexu@...cent.com>
> Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
> v1 -> v2 Changelog:
> - Refine the commit message and subject; (Dave)
> 
>  arch/x86/include/asm/cpufeatures.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

$ test-apply.sh /tmp/urgent.01
checking file arch/x86/include/asm/cpufeatures.h
Hunk #1 FAILED at 299.
patch: **** malformed patch at line 45: IBPB) */

Don't ever send patches from

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

That thing mangles them.

See Documentation/process/email-clients.rst for further info.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette