linux-kernel - Re: [PATCH 1/5] clk: mux: Declare u32 *table parameter as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yff2HZ0tbO4nkvig@latitude>
Date:   Mon, 31 Jan 2022 15:45:49 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     kernel test robot <lkp@...el.com>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-clk@...r.kernel.org, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH 1/5] clk: mux: Declare u32 *table parameter as const

On Mon, Jan 31, 2022 at 11:44:25AM +0800, kernel test robot wrote:
> Hi "Jonathan,
> 
> I love your patch! Perhaps something to improve:
> 
[...]
>    drivers/clk/nxp/clk-lpc18xx-cgu.c: In function 'lpc18xx_pll1_recalc_rate':
>    drivers/clk/nxp/clk-lpc18xx-cgu.c:460:13: warning: variable 'stat' set but not used [-Wunused-but-set-variable]
>      460 |         u32 stat, ctrl;
>          |             ^~~~

This is unrelated to my changes, I'll leave it up to the LPC18xx developers.


>    drivers/clk/nxp/clk-lpc18xx-cgu.c: In function 'lpc18xx_cgu_register_div':
> >> drivers/clk/nxp/clk-lpc18xx-cgu.c:545:52: warning: passing argument 2 of 'lpc18xx_fill_parent_names' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      545 |         lpc18xx_fill_parent_names(parents, clk->mux.table, clk->n_parents);
>          |                                            ~~~~~~~~^~~~~~

I'll fix this for v2.


Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)