linux-kernel - Re: [PATCH v2] pinctrl: microchip-sgpio: Fix support for regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jan 2022 12:58:31 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Steen.Hegelund@...rochip.com,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Colin Foster <colin.foster@...advantage.com>
Subject: Re: [PATCH v2] pinctrl: microchip-sgpio: Fix support for regmap

On Mon, Jan 31, 2022 at 10:50 AM Horatiu Vultur
<horatiu.vultur@...rochip.com> wrote:
>
> Initially the driver accessed the registers using u32 __iomem but then
> in the blamed commit it changed it to use regmap. The problem is that now
> the offset of the registers is not calculated anymore at word offset but
> at byte offset. Therefore make sure to multiply the offset with word size.
>
> Acked-by: Steen Hegelund <Steen.Hegelund@...rochip.com>
> Reviewed-by: Colin Foster <colin.foster@...advantage.com>
> Fixes: 2afbbab45c261a ("pinctrl: microchip-sgpio: update to support regmap")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

LGTM,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> ---
> v1->v2:
> - use regmap_get_reg_stride() instead of regmap_config.reg_stride
> ---
>  drivers/pinctrl/pinctrl-microchip-sgpio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
> index 8e081c90bdb2..639f1130e989 100644
> --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
> +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
> @@ -137,7 +137,8 @@ static inline int sgpio_addr_to_pin(struct sgpio_priv *priv, int port, int bit)
>
>  static inline u32 sgpio_get_addr(struct sgpio_priv *priv, u32 rno, u32 off)
>  {
> -       return priv->properties->regoff[rno] + off;
> +       return (priv->properties->regoff[rno] + off) *
> +               regmap_get_reg_stride(priv->regs);
>  }
>
>  static u32 sgpio_readl(struct sgpio_priv *priv, u32 rno, u32 off)
> --
> 2.33.0
>


-- 
With Best Regards,
Andy Shevchenko