linux-kernel - Re: [PATCH v2] pinctrl: microchip-sgpio: Fix support for regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZgzd7_h9qnKeq2c4ERPzeOk0YdkQho5=4GcvY_zSvWjA@mail.gmail.com>
Date:   Mon, 31 Jan 2022 12:09:17 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        lars.povlsen@...rochip.com, Steen.Hegelund@...rochip.com,
        UNGLinuxDriver@...rochip.com, colin.foster@...advantage.com,
        andy.shevchenko@...il.com
Subject: Re: [PATCH v2] pinctrl: microchip-sgpio: Fix support for regmap

On Mon, Jan 31, 2022 at 9:50 AM Horatiu Vultur
<horatiu.vultur@...rochip.com> wrote:

> Initially the driver accessed the registers using u32 __iomem but then
> in the blamed commit it changed it to use regmap. The problem is that now
> the offset of the registers is not calculated anymore at word offset but
> at byte offset. Therefore make sure to multiply the offset with word size.
>
> Acked-by: Steen Hegelund <Steen.Hegelund@...rochip.com>
> Reviewed-by: Colin Foster <colin.foster@...advantage.com>
> Fixes: 2afbbab45c261a ("pinctrl: microchip-sgpio: update to support regmap")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Patch applied for fixes.

I didn't get last weeks fixes to Torvalds this weekend because linux-next
wasn't being compiled, will send the lot with this on top this week.

Yours,
Linus Walleij