linux-kernel - Re: [PATCH] docs: scheduler: Fix outdated parameter of rebalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 01 Feb 2022 16:30:09 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Tang Yizhou <tangyizhou@...wei.com>, peterz@...radead.org,
        mingo@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        zhengbin13@...wei.com, tangyeechou@...il.com,
        Tang Yizhou <tangyizhou@...wei.com>
Subject: Re: [PATCH] docs: scheduler: Fix outdated parameter of
 rebalance_domains

Tang Yizhou <tangyizhou@...wei.com> writes:

> According to the function prototype of rebalance_domains(), its first
> parameter is *rq* and the document need to be updated.
>
> Signed-off-by: Tang Yizhou <tangyizhou@...wei.com>
> ---
>  Documentation/scheduler/sched-domains.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-domains.rst b/Documentation/scheduler/sched-domains.rst
> index 84dcdcd2911c..e57ad28301bd 100644
> --- a/Documentation/scheduler/sched-domains.rst
> +++ b/Documentation/scheduler/sched-domains.rst
> @@ -37,10 +37,10 @@ rebalancing event for the current runqueue has arrived. The actual load
>  balancing workhorse, run_rebalance_domains()->rebalance_domains(), is then run
>  in softirq context (SCHED_SOFTIRQ).
>  
> -The latter function takes two arguments: the current CPU and whether it was idle
> -at the time the scheduler_tick() happened and iterates over all sched domains
> -our CPU is on, starting from its base domain and going up the ->parent chain.
> -While doing that, it checks to see if the current domain has exhausted its
> +The latter function takes two arguments: the runqueue of current CPU and whether
> +the CPU was idle at the time the scheduler_tick() happened and iterates over all
> +sched domains our CPU is on, starting from its base domain and going up the ->parent
> +chain. While doing that, it checks to see if the current domain has exhausted its
>  rebalance interval. If so, it runs load_balance() on that domain. It then checks
>  the parent sched_domain (if it exists), and the parent of the parent and so
>  forth.

This seems to make sense.  Applied, thanks.

jon