[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YflGGM45F3TqERNj@earth.li>
Date: Tue, 1 Feb 2022 14:39:20 +0000
From: Jonathan McDowell <noodles@...th.li>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: Ansuel Smith <ansuelsmth@...il.com>,
Andy Gross <agross@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/17] ARM: dts: qcom: add missing rpm regulators and
cells for ipq8064
On Mon, Jan 31, 2022 at 04:46:18PM -0600, Bjorn Andersson wrote:
> On Mon 17 Jan 19:20 CST 2022, Ansuel Smith wrote:
>
> > Add cells definition for rpm node and add missing regulators for the 4
> > regulator present on ipq8064. There regulators are controlled by rpm and
> > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will
> > reject any regulator change request.
> >
>
> Is the SMB208 mandatory on all ipq8064 designs, or should this be pushed
> out to the device dts?
It's not; the RB3011 uses a different regulator (a TPS563900).
> > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> > ---
> > arch/arm/boot/dts/qcom-ipq8064.dtsi | 35 +++++++++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > index 094125605bea..824cf13dd037 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > @@ -829,10 +829,45 @@ rpm: rpm@...000 {
> > clocks = <&gcc RPM_MSG_RAM_H_CLK>;
> > clock-names = "ram";
> >
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > rpmcc: clock-controller {
> > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc";
> > #clock-cells = <1>;
> > };
> > +
> > + regulators {
> > + compatible = "qcom,rpm-smb208-regulators";
> > +
> > + smb208_s1a: s1a {
> > + regulator-min-microvolt = <1050000>;
> > + regulator-max-microvolt = <1150000>;
> > +
> > + qcom,switch-mode-frequency = <1200000>;
> > + };
> > +
> > + smb208_s1b: s1b {
> > + regulator-min-microvolt = <1050000>;
> > + regulator-max-microvolt = <1150000>;
> > +
> > + qcom,switch-mode-frequency = <1200000>;
> > + };
> > +
> > + smb208_s2a: s2a {
> > + regulator-min-microvolt = < 800000>;
> > + regulator-max-microvolt = <1250000>;
> > +
> > + qcom,switch-mode-frequency = <1200000>;
> > + };
> > +
> > + smb208_s2b: s2b {
> > + regulator-min-microvolt = < 800000>;
> > + regulator-max-microvolt = <1250000>;
> > +
> > + qcom,switch-mode-frequency = <1200000>;
> > + };
> > + };
> > };
> >
> > tcsr: syscon@...00000 {
> > --
> > 2.33.1
> >
J.
--
... "There's no money, there's no weed. It's all been replaced by a fucking
big pile of corpses." -- Lock, Stock and Two Smoking Barrels
Powered by blists - more mailing lists