[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2022 08:37:35 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Aditya Garg <gargaditya08@...e.com>
Cc: "mchehab@...nel.org" <mchehab@...nel.org>,
"mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
"hverkuil@...all.nl" <hverkuil@...all.nl>,
"sergey.senozhatsky@...il.com" <sergey.senozhatsky@...il.com>,
"ribalda@...omium.org" <ribalda@...omium.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
Orlando Chamberlain <redecorating@...tonmail.com>,
"paul@...rm.io" <paul@...rm.io>, Aun-Ali Zaidi <admin@...eit.net>
Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple
T2-attached FaceTime HD Camera
Hi Aditya,
Thank you for the patch, and sorry for the late reply.
On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
> From: Paul Pawlowski <paul@...rm.io>
>
> Adds the requisite device id to support detection of the Apple FaceTime
> HD webcam exposed over the T2 BCE VHCI interface.
>
> Tested-by: Aun-Ali Zaidi <admin@...eit.net>
> Signed-off-by: Paul Pawlowski <paul@...rm.io>
> Signed-off-by: Aun-Ali Zaidi <admin@...eit.net>
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 7c007426e..88dc9e7aa 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> .bInterfaceProtocol = 0,
> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> | UVC_QUIRK_BUILTIN_ISIGHT) },
> + /* Apple FaceTime HD Camera (Built-In) */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x05ac,
> + .idProduct = 0x8514,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
Have you tested that the device doesn't work without this quirk ?
> /* Apple Built-In iSight via iBridge */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> | USB_DEVICE_ID_MATCH_INT_INFO,
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists