linux-kernel - Re: [PATCH] memblock: Remove unused io.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 02 Feb 2022 09:43:37 +0100
From:   Karolina Drobnik <karolinadrobnik@...il.com>
To:     Mike Rapoport <rppt@...nel.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH] memblock: Remove unused io.h include

Hi Mike,

Thanks for taking a look at my patch.

On Tue, 2022-02-01 at 17:26 +0200, Mike Rapoport wrote:
> As Matthew pointed out [1], many architectures put their definition
> of virt_to_phys() in asm/io.h, e.g. 
> 
> arch/powerpc/include/asm/io.h:#define virt_to_phys virt_to_phys
> arch/sh/include/asm/io.h:#define virt_to_phys(address)  ((unsigned
> long)(address))
> arch/x86/include/asm/io.h:#define virt_to_phys virt_to_phys
> 
> which means memblock needs this header for declaration of
> virt_to_phys().
> 
> Although it is included indirectly, let's keep it for now.

OK, will leave it as it is then.


Many thanks,
Karolina